feat(amazon q): removing feature flag for selective transformation and confirmed string changes #6084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nkomonen-amazon
approved these changes
Nov 21, 2024
dhasani23
approved these changes
Nov 21, 2024
Contributor
|
Please confirm with @ntarakad-aws that this should be merged before merging |
ntarakad-aws
force-pushed
the
selective_transform_release
branch
from
ceba7fc to
d9bd85a
Compare
dhasani23
approved these changes
Nov 22, 2024
Contributor
|
Still waiting, will let you know if this should be merged |
Contributor
|
Got a SEV-2, so this will go out next week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Selective transformation changes were released under an IDE feature flag due to backend changes that needed to be fixed.
Solution
In this PR, we are removing the feature flag on the IDE side so the users will now be able to see the form to select if they want to view their changes in one or multiple diffs. If they select multiple diffs in this form, then selective transformation will be invoked.
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.